Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few linting issues #22842

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 24, 2022

This fixes a few small issues I recently introduced


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

R: @jrmccluskey

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey
Copy link
Contributor

(mod final tests)

@github-actions github-actions bot added the go label Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #22842 (5e5b3a1) into master (3f5ddbc) will not change coverage.
The diff coverage is 12.00%.

@@           Coverage Diff           @@
##           master   #22842   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files         713      713           
  Lines       94151    94151           
=======================================
  Hits        69610    69610           
- Misses      23255    23256    +1     
+ Partials     1286     1285    -1     
Flag Coverage Δ
go 51.24% <12.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/graph/fn.go 84.54% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/graphx/translate.go 41.06% <0.00%> (ø)
sdks/go/pkg/beam/core/state/state.go 75.30% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/userstate.go 12.82% <16.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm damccorm merged commit 80ced0f into apache:master Aug 24, 2022
@damccorm damccorm deleted the users/damccorm/linting branch August 24, 2022 17:10
dedocibula pushed a commit to dedocibula/beam that referenced this pull request Sep 15, 2022
* Fix a few linting issues

* Avoid stuttering names
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Sep 29, 2022
* Fix a few linting issues

* Avoid stuttering names
cushon pushed a commit to cushon/beam that referenced this pull request Oct 17, 2022
* Fix a few linting issues

* Avoid stuttering names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants